Open
Conversation
Error in commit ceccdca
Codecov Report
@@ Coverage Diff @@
## development #6435 +/- ##
===============================================
+ Coverage 75.89% 75.93% +0.03%
===============================================
Files 315 315
Lines 10642 10640 -2
Branches 2935 2935
===============================================
+ Hits 8077 8079 +2
+ Misses 2564 2560 -4
Partials 1 1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hy,
This PR fix a problem with this commit ceccdcac1de4316cc33a1067d604a6470c0245ba in file typeahead.directive.ts
In this commit, a function
setActiveis used to modify variable active, but an existing setter exist in the class.I delete the function
setActiveand replace the set of varactivewith the setter.It's possible to add this fix to the version 7. Because the accessibility of typeahead without the fix is bad.
Thanks.